Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: remove unchecked in for loop #253

Merged
merged 3 commits into from
Jan 10, 2024
Merged

perf: remove unchecked in for loop #253

merged 3 commits into from
Jan 10, 2024

Conversation

smol-ninja
Copy link
Member

Closes #242.

@smol-ninja smol-ninja changed the base branch from main to staging January 6, 2024 09:29
@andreivladbrg
test: remove unnecessary unchecked blocks
f05633f 
test: undo changes in Murky.sol
andreivladbrg
andreivladbrg requested changes Jan 6, 2024
View reviewed changes
Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in core, the pragma solidity version must updated to: pragma solidity >=0.8.22;

test/utils/ArrayBuilder.sol Outdated Show resolved Hide resolved
test/utils/BatchBuilder.sol Outdated Show resolved Hide resolved
test/utils/BatchBuilder.sol Outdated Show resolved Hide resolved
test/utils/BatchBuilder.sol Outdated Show resolved Hide resolved
test/utils/BatchBuilder.sol Outdated Show resolved Hide resolved
test/utils/Murky.sol Outdated Show resolved Hide resolved
@smol-ninja
Copy link
Member Author

@andreivladbrg shall I merge this since all conversations have been resolved?

@andreivladbrg
Copy link
Member

yep

@smol-ninja smol-ninja merged commit 7970577 into staging Jan 10, 2024
7 checks passed
@smol-ninja smol-ninja deleted the perf/unchecked branch January 10, 2024 10:52
@PaulRBerg
Copy link
Member

Same as in core, the pragma solidity version must updated to: pragma solidity >=0.8.22;

For future PRs that change the pragma or the compiler: note that you can head to the "Actions" tab and trigger a manual run of the Multibuild CI:

SCR-20240110-lpcu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulRBerg PaulRBerg PaulRBerg left review comments

@andreivladbrg andreivladbrg andreivladbrg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "unchecked" in for loop incrementors
3 participants
@smol-ninja @andreivladbrg @PaulRBerg