chore: remove etherscan API keys #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As realized in #748, keeping the Etherscan API keys in version control is not worth the maintenance cost.
andreivladbrg
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Are we planning to close that PR? Trying to understand why we have separate PR for this specific thing
smol-ninja
requested changes
Jan 9, 2024
Eventually, yes. Just never found the time to review it.
I need it for another PR. |
smol-ninja
approved these changes
Jan 9, 2024
This was referenced Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As realized in #748, keeping the Etherscan API keys in version control is not worth the maintenance cost.
We only need these keys at deployment time.