build: multi-chain deployment script

[PaulRBerg]

great job @andreivladbrg, I like the script. Let me know what you think about my changes.

[PaulRBerg]

It looks like forge script supports a --multi parameter:

If present, --resume or --verify will be assumed to be a multi chain deployment

Are you aware of this, @smol-ninja, @andreivladbrg? Might be worth digging this up.

[smol-ninja]

Yes. I have used it before. In order to use it, we will have to explicitly specify it in the script files. Since we will still need an option to select chains to deploy on (could be because of higher gas fee on one chain at the time of deployment), the script will be required to take list of chains as input.

This works without using --multi flag as its part of the solidity script code. What --multi flag does is make --verify to work alongside multi chain deployment.

IMO it does not add any additional benefit other than handing over the multi deployment logic to the script files.

function run() {
    vm.createSelectFork(POLYGON_RPC_URL);
    vm.startBroadcast();
    
    vm.stopBroadcast();
    
     vm.createSelectFork(ETHEREUM_RPC_URL);
    vm.startBroadcast();
    
    vm.stopBroadcast();
}

[PaulRBerg]

LGTM except for the admin addresses that can be hard-coded directly in the script. I've pushed a commit myself.

Good to merge, but as I've said here, we should do some more testing when we get to deploy V2.2.

[PaulRBerg]

IMO it does not add any additional benefit other than handing over the multi deployment logic to the script files.

Agree. Thanks for explaining!

[PaulRBerg]

Feel free to accept the PR and merge it @smol-ninja @andreivladbrg.

[PaulRBerg]

@andreivladbrg - you have the honor to squash and merge.