-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external LLVM compatibility to INSTALL.md #131627
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
@nikic Kindly look this |
Better to use a more informative title like "Add external LLVM compatibility to INSTALL.md" (which tgross35 has done for you in the previous PR.) |
thankyou @tgross35 |
Please take a careful look at the existing document. Where are other minimum versions specified? Where is the other mention of LLVM? You will want to add this information there. Please also check whether what you wrote is compatible with the information at https://rustc-dev-guide.rust-lang.org/backend/updating-llvm.html. Think especially hard about whether the "maximum LLVM version" you're adding makes sense. That's as much babysitting as I'm willing to provide. Please put at least a minimal amount of effort into your PRs. |
@manishwalia15 also, please do not make new pull requests for the same change, it is impossible to keep track of review that way (#131622 and #131619 are the same change). Instead, you need to push to the same branch so the existing PR gets updated. Based on the branch names it looks like you are using the GitHub UI to make the changes. Unfortunately it is usually too limited for good workflow - you should instead clone the repository locally, make and commit changes there, and push them back up. If you are newer to git and GitHub workflow, GH has some good documentation on how to do this https://docs.github.com/en/get-started/exploring-projects-on-github/contributing-to-a-project. |
@manishwalia15 |
@manishwalia15 |
No description provided.