-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LLVM compatibility to CONTRIBUTING.md #131622
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
r? llvm My sense is that this is probably not going to be kept up to date, which makes it not very useful. I'm also not sure we have any real policy on this -- my sense is that the versions are really just "whatever is tested in our CI"? |
Failed to set assignee to
|
@manishwalia15 Please do not open a new PR for every revision. |
|
||
To build `rustc`, it is important to know which versions of LLVM are supported. As of Rust 1.82, the following external LLVM versions are supported: | ||
|
||
- **Minimum Supported Version**: LLVM 17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not the right version, we don't support LLVM 17 anymore. Where are you getting this information?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#131588 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mybe
Kindly tell where is the mistake |
See: #130487 The minimum was raised to LLVM 18. |
shall i update to 18..rest is fine ? |
Maybe we should figure out if it's truly helpful to add this to |
Please do tell |
https://github.com/rust-lang/rust/blob/master/INSTALL.md#dependencies would be a more appropriate place. |
You can update your PR instead of opening a new one each time. |
sorry @slanterns i didn knew |
No description provided.