Add workflow script for repository management #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
force-pushed
the
Add_workflow_script_for_repository_management
branch
from
e377948 to
cd8b2cc
Compare
pocke
force-pushed
the
Add_workflow_script_for_repository_management
branch
from
8e7a770 to
60fa4b2
Compare
pocke
requested review from
ksss,
ybiquitous,
yykamei,
soutaro,
takahashim and
VTRyo
as code owners
ybiquitous
approved these changes
Mar 18, 2024
|
Oops. Is this error expected? https://github.com/ruby/gem_rbs_collection/actions/runs/8321546351/job/22767965381?pr=520#step:4:10 |
Yes, it's because this PR has not merged yet. The workflow loads the This error will be recovered after this PR is merged. |
|
Got it! 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the gem ownership management.
The primary purpose is that the community manages RBS files for gems.
The design doc is here: https://hackmd.io/OBmj4M3tT8SOUXdGjKqntg
Read this document for details.
What
This PR adds GHA workflows to merge PR by contributors and gem reviewers themselves.
Why
Previously, I was the bottleneck of this repository. I needed to review and merge all PRs.
This PR changes the situation. It will achieve real community-driven RBS files. Any contributor can write RBS and become a maintainer without admin permission
How
The main feature is
/mergecomment command. The PR author or Gem Reviewer can trigger this command by commenting/mergeon a PR. It checks the PR is ready to be merged, then merge the PR.For former CODEOWNERS
I'll migrate the CODEOWNERS to another approach. In the new approach, they are called "Gem Reviewers".
You all will be removed from the collaborator of this repository. But your permissions will be migrated to the "Gem Reviewers" one.
The responsibilities have not changed. Thanks for maintaining gems continuously.
The reviewing procedure has small changes. See the CONTRIBUTING.md.
The main change is that a Gem Reviewer can merge a PR related to the maintained gem themselves. Previously, a code owner needed to wait for approval from the repository admin. You can manage RBSs more comfortably.