Stop recommending git submodule #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
git submodulesuggestion from the boilerplate generator and the document.This change is for #520.
In the new system, A PR author can merge the PR if it includes only files under
gems/GEM_NAME/. But.gitmodulesfile is on the root directory.I think the submodule is rarely utilized, and it introduces other difficulties (slow
git clone, traps on renaming directories, and so on). Therefore, I'd like to stop adding a new submodule to this repository.This PR does not remove existing submodules. They can still be available. (Perhaps I will remove them in the future if no one uses them)
BTW, the script, which will be introduced in #520, can turn on the submodule support if there is a demand. I'll decide whether it supports
git submoduleor not after a while.