Use "OpenPGP" instead of "PGP" #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
reviewed
Dec 6, 2024
There was a problem hiding this comment.
I have noticed there still are some occurrences of only PGP in dnf-behave-tests/dnf/distro-sync.feature and dnf-behave-tests/dnf/gpg.feature.
It seems the steps stdout/stderr contains lines matching only check if there is a line that contains the string.
Based on the name of the step it would make more sense to me if it checked that the whole line matches.
|
Lets merge this now to fix the CI, we can address my previous comment in a follow up PR if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For rpm-software-management/dnf5#1931.