Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "OpenPGP" instead of "PGP" in distro-sync, gpg #1608

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

evan-goode
Copy link
Member

Following up from this comment: #1601 (review).

These lines do use .* in some places, so instead of converting them to stderr contains lines, I added ^ and $ to further constrain the regex.

@evan-goode evan-goode requested a review from kontura December 11, 2024 17:00
@kontura
Copy link
Contributor

kontura commented Dec 12, 2024

I was thinking if the steps stderr/stdout contains lines matching should add the ^ and $ automatically for all lines?

What do you think?

@kontura kontura self-assigned this Dec 12, 2024
@evan-goode
Copy link
Member Author

Sounds good, tests are passing locally with that change.

Copy link
Contributor

@kontura kontura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@kontura kontura merged commit 3128134 into rpm-software-management:main Dec 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants