Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed labels_to_edges typo #104

Merged
merged 3 commits into from
May 31, 2024
Merged

Fixed labels_to_edges typo #104

merged 3 commits into from
May 31, 2024

Conversation

alex-1001
Copy link
Contributor

No description provided.

@JoOkuma
Copy link
Member

JoOkuma commented May 27, 2024

cc @ilan-theodoro, any guess why the API tests are failing?
They passed on #102 and this PR is a minor fix that went through our review.

@ilan-theodoro
Copy link
Member

@JoOkuma It failed on an ome-zarr function. I checked, and the previous workflow run used ome-zarr==0.8.3, but this one is ome-zarr==0.9.0. This latter version was released a few days ago, so that is why.

I think the fix is easy (not the trivial one of pinning the package 😆) but I personally prefer to drop the dependency in favor of using iohub

@JoOkuma
Copy link
Member

JoOkuma commented May 29, 2024

I'm all for using iohub, we can even make another PR so the segments are in ome-zarr format.
In hindsight I should have been pro it since the beginning.

@JoOkuma JoOkuma merged commit 8a7ffaf into main May 31, 2024
5 of 7 checks passed
@TeunHuijben TeunHuijben deleted the alex-1001-patch-1 branch June 7, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants