Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should be testing humble, and should be using jammy. #1884

Merged
merged 2 commits into from
Dec 17, 2024
Merged

It should be testing humble, and should be using jammy. #1884

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d54179a
It should be testing humble, and should be using jammy.
clalancette Dec 16, 2024
c7410d4
Also remove the cppcheck linter.
clalancette Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
name: ament_${{ matrix.linter }}
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-focal-ros-rolling-ros-base-latest
image: rostooling/setup-ros-docker:ubuntu-jammy-ros-humble-ros-base-latest
strategy:
fail-fast: false
matrix:
Expand All @@ -18,7 +18,7 @@ jobs:
- uses: ros-tooling/[email protected]
with:
linter: ${{ matrix.linter }}
distribution: rolling
distribution: humble
package-name: |
ros2bag
rosbag2
Expand All @@ -38,17 +38,17 @@ jobs:
name: ament_${{ matrix.linter }}
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-focal-ros-rolling-ros-base-latest
image: rostooling/setup-ros-docker:ubuntu-jammy-ros-humble-ros-base-latest
strategy:
fail-fast: false
matrix:
linter: [cppcheck, cpplint, uncrustify]
fujitatomoya marked this conversation as resolved.
Show resolved Hide resolved
linter: [cpplint, uncrustify]
steps:
- uses: actions/checkout@v4
- uses: ros-tooling/[email protected]
with:
linter: ${{ matrix.linter }}
distribution: rolling
distribution: humble
package-name: |
rosbag2_compression
rosbag2_compression_zstd
Expand All @@ -65,11 +65,11 @@ jobs:
name: ament_${{ matrix.linter }}
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-focal-ros-rolling-ros-base-latest
image: rostooling/setup-ros-docker:ubuntu-jammy-ros-humble-ros-base-latest
strategy:
fail-fast: false
matrix:
linter: [cppcheck, cpplint, clang_format]
linter: [cpplint, clang_format]
include:
- linter: clang_format
arguments: "--config rosbag2_storage_mcap/.clang-format"
Expand All @@ -79,14 +79,14 @@ jobs:
with:
linter: ${{ matrix.linter }}
arguments: ${{ matrix.arguments }}
distribution: rolling
distribution: humble
package-name: rosbag2_storage_mcap

ament_lint_python: # Linters applicable to Python packages
name: ament_${{ matrix.linter }}
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-focal-ros-rolling-ros-base-latest
image: rostooling/setup-ros-docker:ubuntu-jammy-ros-humble-ros-base-latest
strategy:
fail-fast: false
matrix:
Expand All @@ -96,7 +96,7 @@ jobs:
- uses: ros-tooling/[email protected]
with:
linter: ${{ matrix.linter }}
distribution: rolling
distribution: humble
package-name: |
ros2bag
rosbag2_py
Loading