It should be testing humble, and should be using jammy. #1884
Conversation
clalancette
commented
Dec 16, 2024
•
clalancette
commented
- This PR fixes GitHub workflow to use Humble base images instead of Rolling.
Signed-off-by: Chris Lalancette <[email protected]>
clalancette
requested review from
gbiggs and
emersonknapp
and removed request for
a team
It is disabled in our CI anyway, because it is far too slow nowadays. Signed-off-by: Chris Lalancette <[email protected]>
There was a problem hiding this comment.
@clalancette thank you very much for the fix.
so technically we should do the same thing to jazzy branch as well?
There was a problem hiding this comment.
lgtm with github workflow.
@MichaelOrlov @christophfroehlich either of you can take a look? thanks in advance.
|
@christophebedard @christophfroehlich thanks for both of you! and sorry 😓 |
|
@ros-pull-request-builder retest this please https://build.ros2.org/job/Hpr__rosbag2__ubuntu_jammy_amd64/303/testReport/junit/rosbag2_transport/RecordIntegrationTestFixture/write_split_callback_is_called/ is obviously unrelated to this PR, these tests are just unstable? CC: @MichaelOrlov |
|
@fujitatomoya Yes, changes are unrelated to the test failures I belive. |
|
@ros-pull-request-builder retest this please |
ah i see that jazzy does not have problem like this. |
Yes, agreed. I can't see how the github workflow would affect the Hpr job. So with that, and the approvals, I'm going to go ahead and merge this. Thanks everyone for reviewing! |
