Allow event statuses to be taken anytime #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yadunund
force-pushed
the
yadu/refactor_events
branch
from
41b5de7 to
35ac6a0
Compare
Yadunund
force-pushed
the
yadu/refactor_events
branch
3 times, most recently
from
eb3058c to
937d33b
Compare
Signed-off-by: Yadunund <[email protected]>
Yadunund
force-pushed
the
yadu/refactor_events
branch
from
937d33b to
c872432
Compare
|
Alright i've ran tests across |
clalancette
approved these changes
Dec 30, 2024
|
@Mergifyio backport humble jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
Signed-off-by: Yadunund <[email protected]> (cherry picked from commit 6098711)
mergify bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
Signed-off-by: Yadunund <[email protected]> (cherry picked from commit 6098711)
This was referenced Jan 2, 2025
Yadunund
added a commit
that referenced
this pull request
Jan 2, 2025
Signed-off-by: Yadunund <[email protected]> (cherry picked from commit 6098711) Co-authored-by: yadunund <[email protected]>
Yadunund
added a commit
that referenced
this pull request
Jan 2, 2025
Signed-off-by: Yadunund <[email protected]> (cherry picked from commit 6098711) Co-authored-by: yadunund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #317
Certain tests in
rclcpp, eg.test_publisherandtest_qos_eventexpect to retrieve event statuses even if an event was not actually triggered. In these cases an event status withtotal_count_changeandcurrent_count_changewith values of0is expected.We now maintain a fixed set of status variables in the
EventsManagerfor each event we support. Graph events directly modify the same statuses which greatly simplifies the implementation inGraphCache.