`WaitForTopics`: get content of messages for each topic #353

LastStarDust · 2023-02-13T03:02:33Z

LastStarDust · 2023-02-13T03:06:14Z

I don't understand why the DCO action is failing. The only commit in this pull-request already has a signed-off-by line in the description ...

clalancette · 2023-02-13T13:29:34Z

I don't understand why the DCO action is failing. The only commit in this pull-request already has a signed-off-by line in the description ...

It's because it is in the wrong format. It should be:

Signed-off-by: Giorgio Pintaudi <[email protected]>

LastStarDust · 2023-02-13T13:50:40Z

@clalancette Thank you for pointing that out. I fixed it.

launch_testing_ros/launch_testing_ros/wait_for_topics.py

adityapande-1995

Thanks for following up ! A couple of minor comments.

launch_testing_ros/launch_testing_ros/wait_for_topics.py

adityapande-1995

Looks good to me, but I'd be nice if @methylDragon or @wjwwood could also take a look.

launch_testing_ros/launch_testing_ros/wait_for_topics.py

launch_testing_ros/test/examples/wait_for_topic_launch_test.py

launch_testing_ros/launch_testing_ros/wait_for_topics.py

launch_testing_ros/test/examples/wait_for_topic_launch_test.py

LastStarDust · 2023-03-13T02:51:57Z

@adityapande-1995 The CI/CD pipeline is failing with the error:

E   ModuleNotFoundError: No module named 'launch.some_entities_type'

However, I think this is not related to any changes I have made.
It might be related to this upstream commit.

LastStarDust · 2023-03-15T01:07:34Z

@adityapande-1995 @clalancette
I added a commit b5a0e09 where I fix what I think is an inconsistency in the code: if the wait method is called multiple times in a row, the same subscribers are recreated even if they already exist.

wait_for_node_object = WaitForTopics(topic_list, timeout=2.0)
wait_for_node_object.wait()
wait_for_node_object.wait() # <-- here the subscribers to the topic_list topics are recreated even if they already exist
wait_for_node_object.shutdown()

LastStarDust · 2023-05-22T03:40:21Z

@adityapande-1995
Hello. Sorry to bother you again. I would like to know what is the review status of this pull request.
Is there anything I can do to help you in the review?

I noticed that the CI was failing probably because of a network error on the servers.
Is there a way to rerun the CI without pushing a new commit?

ros2#346 Signed-off-by: Pintaudi Giorgio <[email protected]>

Signed-off-by: Pintaudi Giorgio <[email protected]>

adityapande-1995 · 2023-06-16T17:30:42Z

I'll run full CI again, thanks for following up !

adityapande-1995 · 2023-06-16T17:39:27Z

Linux
Linux-aarch64
Windows

adityapande-1995 · 2023-06-16T18:50:11Z

@LastStarDust looks like we have one small error, you can test locally using pyflakes

Signed-off-by: Pintaudi Giorgio <[email protected]>

LastStarDust · 2023-06-19T01:07:22Z

@adityapande-1995
I think I fixed that error in the latest commit.

Unfortunately, when I checked the syntax with pyflakes (2.4.0 Python 3.9.13 on Windows) locally, I did not see the errors/warnings that are reported in the CI. So I am assuming you use different settings from the defaults.

So if you notice another flake8 error in the next CI, I beg you to run the linter with the correct settings and tell me exactly what is wrong, or at least tell me how to correctly set up the linter.

adityapande-1995 · 2023-06-21T00:01:14Z

@osrf-jenkins retest this please

adityapande-1995 · 2023-06-22T16:46:54Z

Linux
Linux-aarch64
Windows

Ryanf55 · 2023-08-15T16:59:47Z

Great addition! I was just augmenting some test fixtures to add support for this.

Is there any way this could be backported from rolling to iron and humble? In reviewing the public API changes, the arguments added to functions all have default options, so it shouldn't break consumers using class WaitForTopics. Happy to help.

Ryanf55 · 2023-08-17T16:06:37Z

@Mergifyio backport iron
@Mergifyio backport humble

mergify · 2023-08-17T16:06:40Z

backport iron

❌ Command disallowed due to command restrictions in the Mergify configuration.

sender-permission>=write

Ryanf55 · 2023-08-17T16:07:32Z

@adityapande-1995 Would you be able to run the backport commands for this PR to iron and humble? I do not have permission. Much appreciated!

In commit 0c081a7 (#360) we increased the timeout to 10 seconds to accomodate slower discovery. However, this was partially reverted in 2d125a5 (#353). Restore the 10 second timeout to avoid flakes on the buildfarm. Signed-off-by: Chris Lalancette <[email protected]>

mjcarroll · 2024-01-16T22:27:49Z

https://github.com/Mergifyio backport iron
https://github.com/Mergifyio backport humble

mergify · 2024-01-16T22:27:53Z

backport iron

✅ Backports have been created

#388 WaitForTopics: get content of messages for each topic (backport #353) has been created for branch iron

* Get content of topic from launch_testing_ros::WaitForTopics #346 Signed-off-by: Pintaudi Giorgio <[email protected]> --------- Signed-off-by: Pintaudi Giorgio <[email protected]> (cherry picked from commit 2d125a5)

* Get content of topic from launch_testing_ros::WaitForTopics #346 Signed-off-by: Pintaudi Giorgio <[email protected]> --------- Signed-off-by: Pintaudi Giorgio <[email protected]> (cherry picked from commit 2d125a5) Signed-off-by: Aditya Pande <[email protected]>

adityapande-1995 · 2024-01-16T23:50:09Z

https://github.com/Mergifyio backport humble

mergify · 2024-01-16T23:50:14Z

backport humble

✅ Backports have been created

#389 WaitForTopics: get content of messages for each topic (backport #353) has been created for branch humble but encountered conflicts

* Get content of topic from launch_testing_ros::WaitForTopics #346 Signed-off-by: Pintaudi Giorgio <[email protected]> --------- Signed-off-by: Pintaudi Giorgio <[email protected]> (cherry picked from commit 2d125a5) # Conflicts: # launch_testing_ros/launch_testing_ros/wait_for_topics.py # launch_testing_ros/test/examples/wait_for_topic_launch_test.py

* Get content of topic from launch_testing_ros::WaitForTopics #346 Signed-off-by: Pintaudi Giorgio <[email protected]> --------- Signed-off-by: Pintaudi Giorgio <[email protected]> (cherry picked from commit 2d125a5) # Conflicts: # launch_testing_ros/launch_testing_ros/wait_for_topics.py # launch_testing_ros/test/examples/wait_for_topic_launch_test.py Signed-off-by: Aditya Pande <[email protected]>

* Get content of topic from launch_testing_ros::WaitForTopics #346 --------- (cherry picked from commit 2d125a5) Signed-off-by: Pintaudi Giorgio <[email protected]> Signed-off-by: Aditya Pande <[email protected]> Co-authored-by: Giorgio Pintaudi <[email protected]>

… (#389) * `WaitForTopics`: get content of messages for each topic (#353) * Get content of topic from launch_testing_ros::WaitForTopics #346 Signed-off-by: Pintaudi Giorgio <[email protected]> --------- Signed-off-by: Pintaudi Giorgio <[email protected]> (cherry picked from commit 2d125a5) # Conflicts: # launch_testing_ros/launch_testing_ros/wait_for_topics.py # launch_testing_ros/test/examples/wait_for_topic_launch_test.py Signed-off-by: Aditya Pande <[email protected]> * Resolve conflicts (#390) Signed-off-by: Ryan Friedman <[email protected]> Signed-off-by: Aditya Pande <[email protected]> --------- Signed-off-by: Pintaudi Giorgio <[email protected]> Signed-off-by: Aditya Pande <[email protected]> Signed-off-by: Ryan Friedman <[email protected]> Co-authored-by: Giorgio Pintaudi <[email protected]> Co-authored-by: Ryan <[email protected]>

LastStarDust requested review from adityapande-1995 and methylDragon as code owners February 13, 2023 03:02

LastStarDust mentioned this pull request Feb 13, 2023

Get content of topic from launch_testing_ros::WaitForTopics #346

Closed

LastStarDust force-pushed the feature/get-message-content branch from 6d01e84 to 8143f1d Compare February 13, 2023 13:49

adityapande-1995 requested changes Feb 13, 2023

View reviewed changes

launch_testing_ros/launch_testing_ros/wait_for_topics.py Outdated Show resolved Hide resolved

LastStarDust force-pushed the feature/get-message-content branch 2 times, most recently from da2fa90 to 7a86ed1 Compare February 28, 2023 06:55

LastStarDust changed the title ~~Get content of topic from launch_testing_ros::WaitForTopics~~ WaitForTopics: get content of messages for each topic Mar 1, 2023

adityapande-1995 requested changes Mar 1, 2023

View reviewed changes

launch_testing_ros/launch_testing_ros/wait_for_topics.py Outdated Show resolved Hide resolved

launch_testing_ros/launch_testing_ros/wait_for_topics.py Outdated Show resolved Hide resolved

launch_testing_ros/launch_testing_ros/wait_for_topics.py Outdated Show resolved Hide resolved

adityapande-1995 approved these changes Mar 6, 2023

View reviewed changes

wjwwood reviewed Mar 10, 2023

View reviewed changes

adityapande-1995 requested changes Mar 10, 2023

View reviewed changes

launch_testing_ros/launch_testing_ros/wait_for_topics.py Outdated Show resolved Hide resolved

launch_testing_ros/test/examples/wait_for_topic_launch_test.py Show resolved Hide resolved

LastStarDust force-pushed the feature/get-message-content branch 3 times, most recently from d9fbc1b to 8249e34 Compare March 13, 2023 02:47

LastStarDust and others added 9 commits May 22, 2023 13:29

Get content of topic from launch_testing_ros::WaitForTopics

8656009

ros2#346 Signed-off-by: Pintaudi Giorgio <[email protected]>

Use deque instead of list and added unit tests

e6d2af3

Signed-off-by: Pintaudi Giorgio <[email protected]>

return a list to not expose implementation details (deque)

3ad48ec

Signed-off-by: Pintaudi Giorgio <[email protected]>

Fixed flake8 errors

41643b6

Signed-off-by: Pintaudi Giorgio <[email protected]>

WaitForTopic: better naming of variables and methods

9f214fc

Signed-off-by: Pintaudi Giorgio <[email protected]>

WaitForTopic: better naming of variables and methods (bugfix)

5b015fc

Signed-off-by: Pintaudi Giorgio <[email protected]>

Update launch_testing_ros/launch_testing_ros/wait_for_topics.py

de7266c

Signed-off-by: Pintaudi Giorgio <[email protected]>

Update launch_testing_ros/launch_testing_ros/wait_for_topics.py

595a1c7

Signed-off-by: Pintaudi Giorgio <[email protected]>

Update launch_testing_ros/test/examples/wait_for_topic_launch_test.py

64a4dcf

Signed-off-by: Pintaudi Giorgio <[email protected]>

Fixed import ordering

1144f61

Signed-off-by: Pintaudi Giorgio <[email protected]>

adityapande-1995 merged commit 2d125a5 into ros2:rolling Jun 22, 2023

LastStarDust deleted the feature/get-message-content branch June 23, 2023 01:18

clalancette mentioned this pull request Aug 24, 2023

Increase the timeout in wait_for_topic_launch_test. #377

Merged

mergify bot mentioned this pull request Jan 16, 2024

WaitForTopics: get content of messages for each topic (backport #353) #388

Merged

mergify bot mentioned this pull request Jan 16, 2024

WaitForTopics: get content of messages for each topic (backport #353) #389

Merged

Ryanf55 mentioned this pull request Jan 17, 2024

Fix conflicts in Mergify/bp/humble/pr 353 #390

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`WaitForTopics`: get content of messages for each topic #353

`WaitForTopics`: get content of messages for each topic #353

LastStarDust commented Feb 13, 2023

LastStarDust commented Feb 13, 2023

clalancette commented Feb 13, 2023

LastStarDust commented Feb 13, 2023

adityapande-1995 left a comment

adityapande-1995 left a comment

LastStarDust commented Mar 13, 2023 •

edited

Loading

LastStarDust commented Mar 15, 2023 •

edited

Loading

LastStarDust commented May 22, 2023

adityapande-1995 commented Jun 16, 2023

adityapande-1995 commented Jun 16, 2023

adityapande-1995 commented Jun 16, 2023

LastStarDust commented Jun 19, 2023 •

edited

Loading

adityapande-1995 commented Jun 21, 2023

adityapande-1995 commented Jun 22, 2023

Ryanf55 commented Aug 15, 2023

Ryanf55 commented Aug 17, 2023

mergify bot commented Aug 17, 2023

Ryanf55 commented Aug 17, 2023

mjcarroll commented Jan 16, 2024

mergify bot commented Jan 16, 2024 •

edited

Loading

adityapande-1995 commented Jan 16, 2024

mergify bot commented Jan 16, 2024 •

edited

Loading

WaitForTopics: get content of messages for each topic #353

WaitForTopics: get content of messages for each topic #353

Conversation

LastStarDust commented Feb 13, 2023

LastStarDust commented Feb 13, 2023

clalancette commented Feb 13, 2023

LastStarDust commented Feb 13, 2023

adityapande-1995 left a comment

Choose a reason for hiding this comment

adityapande-1995 left a comment

Choose a reason for hiding this comment

LastStarDust commented Mar 13, 2023 • edited Loading

LastStarDust commented Mar 15, 2023 • edited Loading

LastStarDust commented May 22, 2023

adityapande-1995 commented Jun 16, 2023

adityapande-1995 commented Jun 16, 2023

adityapande-1995 commented Jun 16, 2023

LastStarDust commented Jun 19, 2023 • edited Loading

adityapande-1995 commented Jun 21, 2023

adityapande-1995 commented Jun 22, 2023

Ryanf55 commented Aug 15, 2023

Ryanf55 commented Aug 17, 2023

mergify bot commented Aug 17, 2023

❌ Command disallowed due to command restrictions in the Mergify configuration.

Ryanf55 commented Aug 17, 2023

mjcarroll commented Jan 16, 2024

mergify bot commented Jan 16, 2024 • edited Loading

✅ Backports have been created

adityapande-1995 commented Jan 16, 2024

mergify bot commented Jan 16, 2024 • edited Loading

✅ Backports have been created

`WaitForTopics`: get content of messages for each topic #353

`WaitForTopics`: get content of messages for each topic #353

LastStarDust commented Mar 13, 2023 •

edited

Loading

LastStarDust commented Mar 15, 2023 •

edited

Loading

LastStarDust commented Jun 19, 2023 •

edited

Loading

mergify bot commented Jan 16, 2024 •

edited

Loading

mergify bot commented Jan 16, 2024 •

edited

Loading