Fix rqt jtc bugs for continuous joints and other minor bugs #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
DasRoteSkelett,
destogl,
mcbed and
VanshGehlot
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #890 +/- ##
==========================================
- Coverage 47.41% 47.35% -0.06%
==========================================
Files 41 41
Lines 3862 3862
Branches 1816 1816
==========================================
- Hits 1831 1829 -2
Misses 777 777
- Partials 1254 1256 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
christophfroehlich
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
This fixed #886 for me
- Without the limit tags added with URDF: Add limits to the continuous joints ros2_control_demos#387 the rqt_jtc just doesn't work without any warnings: now it does!
- It spins the node more than once in a timer callback, now I always receive the topic
- If there is an error with the topic, it does not add infinite subscriptions.
bmagyar
reviewed
Dec 8, 2023
rqt_joint_trajectory_controller/rqt_joint_trajectory_controller/joint_limits_urdf.py
Outdated
Show resolved
Hide resolved
bmagyar
reviewed
Dec 8, 2023
rqt_joint_trajectory_controller/rqt_joint_trajectory_controller/joint_trajectory_controller.py
Outdated
Show resolved
Hide resolved
bmagyar
reviewed
Dec 8, 2023
rqt_joint_trajectory_controller/rqt_joint_trajectory_controller/joint_trajectory_controller.py
Outdated
Show resolved
Hide resolved
|
Thanks @bmagyar |
mergify bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
(cherry picked from commit e8a127f)
bmagyar
pushed a commit
that referenced
this pull request
Dec 8, 2023
) (cherry picked from commit e8a127f) Co-authored-by: Sai Kishor Kothakota <[email protected]>
This was referenced Dec 9, 2023
christophfroehlich
added
the
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Dec 10, 2023
(cherry picked from commit e8a127f)
christophfroehlich
pushed a commit
that referenced
this pull request
Dec 10, 2023
) (cherry picked from commit e8a127f) Co-authored-by: Sai Kishor Kothakota <[email protected]>
christophfroehlich
pushed a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Dec 15, 2023
…rols#890) (ros-controls#897) (cherry picked from commit e8a127f) Co-authored-by: Sai Kishor Kothakota <[email protected]>
henrygerardmoore
pushed a commit
to henrygerardmoore/ros2_controllers
that referenced
this pull request
Jul 19, 2024
…s#890) * Prevent controller manager from crashing when controller's plugin has error during loading. * Use pydocstyle instead of pep257 because it replaces it. Bump versions of hooks. * Remove fixed python version from formatting action. Fix action warnings about Node.js 12 by updating them. Bump version of clang-format. * correct typo * Bump clang-format version. * Update .pre-commit-config.yaml * Fixup formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes as mentioned by @christophfroehlich (#659 (comment))
This PR aims to fix the issues with drop down and other subscription issues