Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Test against rails 6.1 #332

Merged
merged 5 commits into from
Jul 11, 2022
Merged

[CI] Test against rails 6.1 #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca12c53
add ci
waghanza Jul 19, 2021
aa45aa3
add rails6.1 gemfile
waghanza Jul 19, 2021
37ccb3b
typo
waghanza Dec 8, 2021
529b5ae
add thread_safe for rails 6.1
waghanza Jun 29, 2022
49804a3
bump logstach event version
waghanza Jul 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
gemfile:
- Gemfile
- gemfiles/rails_edge.gemfile # 7.1.0.alpha
- gemfiles/rails_6.1.gemfile
- gemfiles/rails_6.0.gemfile
- gemfiles/rails_5.2.gemfile

Expand Down
19 changes: 19 additions & 0 deletions gemfiles/rails_6.1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# frozen_string_literal: true

source 'https://rubygems.org'

# Specify your gem's dependencies in lograge.gemspec
gemspec path: '..'

group :test do
gem 'actionpack', '~> 6.1.0'
gem 'activerecord', '~> 6.1.0'
# logstash does not release any gems on rubygems, but they have two gemspecs within their repo.
# Using the tag is an attempt of having a stable version to test against where we can ensure that
# we test against the correct code.
gem 'logstash-event', git: 'https://github.com/elastic/logstash', tag: 'v1.5.4'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iloveitaly what is the rational behind using this version ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea :) If this needs to change, lets do it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC (it's been a while), some things changed in the Logstash codebase that removed a class that's depended on in one of Lograge's adapters.

# logstash 1.5.4 is only supported with jrjackson up to 0.2.9
gem 'jrjackson', '~> 0.2.9', platforms: :jruby
gem 'lines'
waghanza marked this conversation as resolved.
Show resolved Hide resolved
gem 'thread_safe'
end