-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Test against rails 6.1 #332
Conversation
Hey @waghanza - Thanks for updating your PR! 🙌 It looks like you’ve just got a couple of Rubocop violations:
I’ll fix them and get this merged in next time I’m in front of a computer unless you get to it first! |
Done @ivy Maybe worth using |
@waghanza tests are still failing. Want to give it another try? Would love to get this change in. |
@iloveitaly @ivy Not sure what is going on ... |
@waghanza still failing, not sure what is going on here. |
Ruby 2.7 / Rails 6 fails and prevent other CI to run |
@iloveitaly |
# logstash does not release any gems on rubygems, but they have two gemspecs within their repo. | ||
# Using the tag is an attempt of having a stable version to test against where we can ensure that | ||
# we test against the correct code. | ||
gem 'logstash-event', git: 'https://github.com/elastic/logstash', tag: 'v1.5.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iloveitaly what is the rational behind using this version ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea :) If this needs to change, lets do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC (it's been a while), some things changed in the Logstash codebase that removed a class that's depended on in one of Lograge's adapters.
Co-authored-by: Ivy Evans <[email protected]>
Hi,
This
PR
adds rails6 in CI matrix.As rails6 require ruby >2.5, I've also excluded jruby from rails6 tests.
Regards,