toggle rotation on click #79
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- closes rodrigo-brito#76 - adds package.lock for versioning of npm modules, yarn version in package.json - generates more complex (chunked js) structure for assets - assumes build is via `make build-with-assets` in master branch, or equivalent - Makefile in stevegt's fork at commit 3a47b3d - see rodrigo-brito#77 for discussion
rodrigo-brito
requested changes
Oct 25, 2021
| @@ -0,0 +1,15281 @@ | |||
| { | |||
There was a problem hiding this comment.
The project uses Yarn instead of NPM, and we have yarn.lock
| @@ -13,7 +13,8 @@ | |||
| "react": "^16.5.2", | |||
| "react-dom": "^16.5.2", | |||
| "react-router-dom": "^4.3.1", | |||
| "sweetalert2": "^7.28.10" | |||
| "sweetalert2": "^7.28.10", | |||
| "yarn": "^1.22.17" | |||
There was a problem hiding this comment.
Please, do not remove yarn.
Comment on lines
+171
to
+173
| new BABYLON.ExecuteCodeAction(BABYLON.ActionManager.OnPickTrigger, () => { | ||
| this.toggleRotation(); | ||
| }) |
There was a problem hiding this comment.
Suggested change
| new BABYLON.ExecuteCodeAction(BABYLON.ActionManager.OnPickTrigger, () => { | |
| this.toggleRotation(); | |
| }) | |
| new BABYLON.ExecuteCodeAction(BABYLON.ActionManager.OnPickTrigger, this.toggleRotation) |
| @@ -208,12 +216,20 @@ class App extends Component { | |||
| }); | |||
| } | |||
|
|
|||
| toggleRotation() { | |||
There was a problem hiding this comment.
Please, you need to include a bind in the constructor for this. Check the constructor for some examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The important bits that address #76 are in App.js. Everything else here and in #78 shows what I needed to do to get the build working.
make build-with-assetsin master branch, or equivalent