-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to stop rotation #76
Comments
For now, we do not have support for it, but it is a great idea. PRs are welcome. |
Do you recall where the javascript is that's controlling that stop/start behavior? I haven't found it yet. |
It is defined here: https://github.com/rodrigo-brito/gocity/blob/front-end/src/App.js#L234 |
Doh! I had been looking for lowercase |
Well, I had something working, but in the shuffling back-and-forth between branches, I seem to have cherry-picked the wrong commit and then hard reset the right one, so this work's lost. May have another go this weekend if I have time. Strongly recommend you consider prioritizing #77. |
- closes rodrigo-brito#76 - adds package.lock for versioning of npm modules, yarn version in package.json - generates more complex (chunked js) structure for assets - assumes build is via `make build-with-assets` in master branch, or equivalent - Makefile in stevegt's fork at commit 3a47b3d - see rodrigo-brito#77 for discussion
Does anyone know how to stop the scene rotation? Right now it stops for about 2 seconds on mouse click, and then restarts automatically. Gives me a headache when I'm trying to analyze a large codebase, makes it too easy to get lost in the streets. ;-) It would be great if it could be made to stop completely, and then restart on next click. I've been looking through the javascript, and I can't even find the handler that's stopping it for those two seconds or so.
Related -- I also can't find the handlers for drag, rotate, zoom. I'm thinking to add more functionality, like pan.
The text was updated successfully, but these errors were encountered: