-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement streaming cartesian commands, create AmorCartesianControl #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinterpret_cast cannot cast away cv qualifiers (asBlob() returns a const char*).
Named pretty much after the same xCallbackPort's command at asibot-main.
This is actually taken care of by 'interruptModule'. Previously, a CTRL+C rendered the terminal useless and never actually killed the process.
Avoid tiny values like 1.23456789e-16.
Makes sense for position-based device controllers (like the LeapMotion).
Per http://docs.ros.org/latest/api/orocos_kdl/html/geomprim.html 3 different types of transformations do exist for the twists and wrenches. * 1) Frame * Twist or Frame * Wrench : * this transforms both the velocity/force reference point * and the basis to which the twist/wrench are expressed. * 2) Rotation * Twist or Rotation * Wrench : * this transforms the basis to which the twist/wrench are * expressed, but leaves the reference point intact. * 3) Twist.RefPoint(v_base_AB) or Wrench.RefPoint(v_base_AB) * this transforms only the reference point. v is expressed * in the same base as the twist/wrench and points from the * old reference point to the new reference point. Previously, pure rotations resulted in applying an additional translation to the TCP. That is, the reference point was being altered. See also sect. 4.2.3 "Transformation of twist coordinates" in: Herman Bruyninckx, "Robot Kinematics and Dynamics", Katholieke Universiteit Leuven, Department of Mechanical Engineering (Leuven, Belgium), 2010.
12 tasks
jgvictores
approved these changes
Oct 27, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PeterBowman Great! Thank you so much!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly aimed at solving #105. Notable changes:
ICartesianControl
.AmorCartesianControl
implementation ofroboticslab::ICartesianControl
for commanding the AMOR manipulator in the task space via official API.KinRepresentation::encodeVelocity
andKinRepresentation::decodeVelocity
.KinRepresentation::parseEnumerator
.ICartesianSolver::diffInvKinEE
method for handling streaming commands with respect to the tool frame.