Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ICartesianControl::movi to pose? #198

Closed
PeterBowman opened this issue May 18, 2024 · 1 comment
Closed

Rename ICartesianControl::movi to pose? #198

PeterBowman opened this issue May 18, 2024 · 1 comment
Assignees
Labels

Comments

@PeterBowman
Copy link
Member

There used to be a streaming pose command: 7af8fc7 (#117). Before its deprecation at 469d103, the documentation stated:

/**
 * @brief Achieve pose (velocity control)
 *
 * Move to desired position, computing the error with respect to the current pose. Then,
 * perform numerical differentiation and obtain the final velocity increment (as in @ref twist).
 *
 * @param x 6-element vector describing desired instantaneous pose in cartesian space;
 * first three elements denote translation (meters), last three denote rotation (radians).
 * @param interval Time interval between successive command invocations, expressed in seconds
 * and used for numerical differentiation with desired/current poses.
 */
void pose(const std::vector<double> & x, double interval);

The movi command was introduced later (87a9c94) with the following description:

/**
 * @brief Achieve pose
 *
 * Move to desired position instantaneously, no further intermediate calculations are
 * expected other than computing the inverse kinematics.
 *
 * @param x 6-element vector describing desired instantaneous pose in cartesian space;
 * first three elements denote translation (meters), last three denote rotation (radians).
 */
void movi(const std::vector<double> & x);

I find the movi name a bit difficult to understand at first glance. Also, ROS users may question the naming of this command due to the existence of Pose, Twist and Wrench geometry message types (ref). Since the information conveyed is in fact a pose, then why not use this name instead?

cc @jgvictores @mercerebo1

@jgvictores
Copy link
Member

jgvictores commented May 19, 2024

LGTM!

BTW, maybe we should be more explicit on the representation of orientation (compact axis/angle, if I recall correctly)?

@PeterBowman PeterBowman self-assigned this May 23, 2024
PeterBowman added a commit to roboticslab-uc3m/amor-yarp-devices that referenced this issue May 23, 2024
PeterBowman added a commit to roboticslab-uc3m/gait-experiments that referenced this issue May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants