feature/mx-1673 full text search support #226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cutoffthetop
changed the title
This was referenced Jan 6, 2025
cutoffthetop
added a commit
that referenced
this pull request
Jan 9, 2025
### PR Context - prep for #226 ### Added - add `extracted_or_rule_labels` to query builder globals ### Changes - rename short and obscure cypher query variables to more expressive and verbose ones ### Fixed - avoid recursive retries in `GraphConnector._check_connectivity_and_authentication` - fix integration tests not properly marked as integration tests
cutoffthetop
added a commit
to robert-koch-institut/mex-common
that referenced
this pull request
Jan 9, 2025
### PR Context - prep for robert-koch-institut/mex-backend#226 - we need to determine the searchable fields for Text and Link objects - Text and Link are subclasses of pydantics BaseModel, not our own - so i needed to add support for any pydantic model to the field util functions - as far as i could determine, `GenericFieldInfo` and `get_all_fields` is not used outside of mex-common at the moment, so we can safely move them around ### Added - BREAKING: add nested models (Text, Link) to *all* lookups in `mex.common.fields` ### Changes - BREAKING: move `GenericFieldInfo` from `models.base.field_info` to `utils` - BREAKING: move `get_all_fields` from `BaseModel` to `utils` to support all base models
…ckend into feature/mx-1673-matched-test-data
cutoffthetop
changed the base branch from
main
to
feature/mx-1673-matched-test-data
…-full-text-search-support-2
cutoffthetop
added a commit
that referenced
this pull request
Jan 9, 2025
# PR Context - prep for #226 # Added - add two matched organizations to the test dummy data # Changed - rename `stable_target_id` to more appropriate `identifier` argument for merged queries
…ckend into feature/mx-1673-full-text-search-support-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Context
Changes
before pulling in nested models as well as identifiers from referenced merged items
and by replacing subqueries with cypher pattern comprehension syntax
componentsin merged queries with_, to be more harmonious with_refsSEARCHABLE_FIELDSandSEARCHABLE_CLASSES(stop-gap MX-1766)