Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx-1673 prepare fulltext search #225

Merged
merged 4 commits into from
Jan 9, 2025
Merged

feature/mx-1673 prepare fulltext search #225

merged 4 commits into from
Jan 9, 2025

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Jan 6, 2025 •
edited
Loading

PR Context

Added

  • add extracted_or_rule_labels to query builder globals

Changes

  • rename short and obscure cypher query variables to more expressive and verbose ones

Fixed

  • avoid recursive retries in GraphConnector._check_connectivity_and_authentication
  • fix integration tests not properly marked as integration tests

@cutoffthetop cutoffthetop self-assigned this Jan 6, 2025
rababerladuseladim
rababerladuseladim approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@rababerladuseladim rababerladuseladim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go!

@cutoffthetop cutoffthetop merged commit f1bbcc4 into main Jan 9, 2025
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1673-renaming branch January 9, 2025 13:15
@cutoffthetop cutoffthetop mentioned this pull request Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rababerladuseladim rababerladuseladim rababerladuseladim approved these changes

Assignees

@cutoffthetop cutoffthetop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cutoffthetop @rababerladuseladim