Add More GNU v2/v3 Tests #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wargio
approved these changes
Dec 2, 2024
|
looks like we do not handle many cases (the copied code is probably old and should be updated?) |
|
Yes, some fixmes lying around. Will fix those... |
Fix breaking tests for gnu v2 demangler
This comment was marked as resolved.
This comment was marked as resolved.
brightprogrammer
force-pushed
the
more_tests
branch
from
87519f0 to
f14490e
Compare
Some test cases are failing because __gnu_cxx is not getting printed in the demangled name. These are marked with AFTER-REWRITE. Some tests are failing because the test is incorrect, these are marked with INCORRECT, which can be checked later on. These are less than 30 in count. Some tests are failing because current demangler code does not handle substitution. For this we need the rewrite. Will work on those in following commit.
XVilka
requested changes
Dec 22, 2024
XVilka
reviewed
Dec 22, 2024
XVilka
requested changes
Dec 22, 2024
XVilka
requested changes
Dec 22, 2024
XVilka
approved these changes
Dec 22, 2024
XVilka
requested changes
Dec 22, 2024
Some tests were failing because of regex replacement performed after demangling, to simplify the demangled output. Thec c++ tests are now split into two parts : test_cxx.c and test_cxx_base.c Full discussion can be viewed in the thread here : https://im.rizin.re/rizinorg/pl/prasfjqxc3fgb8uxxoh565ku4w
XVilka
approved these changes
Dec 23, 2024
|
@wargio take a look again. |
wargio
approved these changes
Dec 23, 2024
wargio
reviewed
Dec 23, 2024
That's the plan. Cover as much as possible with tests before starting actual rewrite. So that we could be sure the new code works properly. |
|
Yes, and in total, only around 300 tests fail in c++ v3 test set. Some return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more tests.
Tests taken and modified from here
Source test code is licensed under BSD, modified test code is licensed under LGPL-3.0-only
Tests taken for gnu v2 are from here
Both source test code and the modified test code is licensed under LGPL v3
Tests taken for gnu v2 are from
libiberty/testsuite/demangle-expectedfrom gcc-2.95.3 source code are licensed under GPL v2