Rewrite Of C++ Demanglers #69
Conversation
- Common types like int, signed char, etc... are being demangled in function params now - Support for custom types in function param list needs to be added. - Support for repeated parameter types.
Now 180 tests pass out of all. Two tests seem to be wrong at the moment, but will take a look later. TODO - Sequence of identical types - Templates - Function params that have qualifier list in their type
src/cp/param.h
Outdated
| ((p) ? (dem_string_free ((p)->name), \ | ||
| dem_string_free ((p)->suffix), \ | ||
| dem_string_free ((p)->prefix), \ | ||
| memset ((p), 0, sizeof (Param)), \ | ||
| (p)) : \ | ||
| NULL) |
There was a problem hiding this comment.
maybe just use a do {} while(0) with an if inside ?
There was a problem hiding this comment.
I like them having as expressions so I can do an if(!expr) {error} on them to debug sometimes.
src/cp/param.h
Outdated
| ((p) ? (((p)->name = dem_string_new()), \ | ||
| ((p)->suffix = dem_string_new()), \ | ||
| ((p)->prefix = dem_string_new()), \ | ||
| (p)) : \ | ||
| NULL) |
There was a problem hiding this comment.
We can convert these after the rewrite is complete, it won't hurt to change them and the code will be going into static mode.
src/cp/param.h
Outdated
| ((param_init (p_dst) && (p_src)) ? (dem_string_concat ((p_dst)->name, (p_src)->name), \ | ||
| dem_string_concat ((p_dst)->suffix, (p_src)->suffix), \ | ||
| dem_string_concat ((p_dst)->prefix, (p_src)->prefix), \ | ||
| (p_dst)) : \ | ||
| NULL) |
There was a problem hiding this comment.
if the purpose is to call this, then maybe just define a function that does this directly in the demangler ?
There was a problem hiding this comment.
Yep, I'll do that. I used this init then concat pattern some other places as well. It'll fix those as well...
| #define nearest_power_of_two(v) \ | ||
| (((v)--), \ | ||
| ((v) |= (v) >> 1), \ | ||
| ((v) |= (v) >> 2), \ | ||
| ((v) |= (v) >> 4), \ | ||
| ((v) |= (v) >> 8), \ |
There was a problem hiding this comment.
instead of reinventing the wheel, why not copying the code from rizin side?
There was a problem hiding this comment.
Yea, sorry about that 😅 I have a habit of doing that. The plus point is that src/cp will be a completely independent module on it's own if we just provide a DemString to it. Maybe that's good...?
There was a problem hiding this comment.
just define one like DemString (which is an extract of RzStrBuf) which any other demangler can use.
|
We do need to find a way to test the GNU v2 code more like we do for GNU v3. There are very few examples. Also due to lack of a precise grammar, things like special naming conventions are hard for me to cover. Any suggestions? |
|
There are some function parameter types for which tests don't exist. I haven't added them for now, because I won't have any way to test my implementation. |
| @@ -11,6 +11,10 @@ Files: .clang-format | |||
| Copyright: 2020 RizinOrg <[email protected]> | |||
| License: LGPL-3.0-only | |||
|
|
|||
| Files: src/cp/.clang-format | |||
There was a problem hiding this comment.
Maybe move this out of cp and make it global in the root dir?
There was a problem hiding this comment.
Doing that in a separate PR might be a good idea though. If introduced right now, it might make the diff noisy.
There was a problem hiding this comment.
yes you can submit this in another PR where you patch all the diffs.
Remove old GPL code from libiberty and completely rewrite both GNU v2 and GNU v3 demanglers with LGPL license.
Work plan :
src/gnu_v2src/cxxTest plan :