Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Controls Changes #64

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Controls Changes #64

merged 5 commits into from
Dec 11, 2023

Conversation

Picklze1
Copy link
Contributor

@Picklze1 Picklze1 commented Dec 11, 2023

Changes;

  • Swapped controls in TeleOp
  • Editing Comments
  • Editing Telemetry
    (Drafted)

Copy link
Contributor

@RZW-13 RZW-13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark these changes in the telemetry message

@Picklze1 Picklze1 marked this pull request as ready for review December 11, 2023 17:26
@Picklze1 Picklze1 requested a review from RZW-13 December 11, 2023 17:26
* X = Claw Lock + (Manual)
* Y = Claw Lock - (Manual)
* Left Bumper = Claw Lock + (Manual)
* Left Trigger = Claw Lock - (Manual)
* D Pad Up = VS Up (Manual)
* D Pad Down = VS Down (Manual)
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we please get rid of this comment...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine

@Picklze1 Picklze1 requested a review from RZW-13 December 11, 2023 20:52
* D Pad Up = VS Up (Manual)
* D Pad Down = VS Down (Manual)
*/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix this.

Copy link
Contributor

@RZW-13 RZW-13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@Picklze1 Picklze1 merged commit 5fce7be into master Dec 11, 2023
@RZW-13 RZW-13 deleted the George-Jensen-Controls-Fix branch December 11, 2023 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants