Fixes for valgrind and rawhide static builds #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danrodrig
commented
Jan 24, 2024
danrodrig
commented
- Suppressed ReallocZero error from libproxy/duktape, closes Valgrind is currently failing due to libproxy #310
- Bumped third-party OpenSSL to 1.1.1w to fix 404s in downloads
- Declared build_type_safety_c 2 for Fedora 40 static builds, closes Restraint is no longer buildable on Fedora Rawhide with static libraries #314
- Bumped third-party json-c to 0.16 to avoid calloc-transposed-args errors in Fedora 40, relates to Restraint is no longer buildable on Fedora Rawhide with static libraries #314
Suppressed Valgrind realloc size zero errors from duktape library used by libproxy starting with version 0.5.
Lower the level below 3 in static builds to avoid failures due to incompatible-pointer-types.
Recent json-c versions solved calloc-transposed-args related warnings which started showing in Fedora 40. Note that the latest json-c version is 0.17 and requires cmake 3.9 or higher for building, which complicates the CentOS 7 support.
This was referenced Jan 24, 2024
StykMartin
approved these changes
Jan 25, 2024
For json-c I didn't jump to 0.7 because CentOS 7. It can be built with cmake3 from epel but it needs tweaking to use it. And as CentOS 7 will be gone in June, I didn't bothered. I mentioned in the commit. For OpenSSL the current supported series are 3.0, 3.1 and 3.2. Rawhide is using 3.1.4, the version here, 1.1.1w, is out of support. https://www.openssl.org/source/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.