-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup requests dependency and move to examples group #19
Conversation
thanks @izofat ! Sorry the issue was not very detailed, I think another point to address would be the README instructions, for example |
Thanks for the feedback. |
thank you @izofat , the README looks better. I think you can define groups from other groups rather than repeating dependencies which should make pyproject.toml more maintainable, could you please have a look? https://peps.python.org/pep-0735/#example-dependency-groups-table |
@aclerc |
define all using other groups
@izofat I found a solution after checking how the OpenOA repo does it https://github.com/NREL/OpenOA/blob/main/pyproject.toml |
* Update smarteole_example.ipynb fix issue, CACHE_SUBDIR is missing if data has never been downloaded * Update smarteole_example.ipynb fix ruff issue * Update smarteole_example.ipynb try to fix ruff issue * fix issues after updating ruff * Fix plotconfig mkdir (#16) * remove make_plots_dir * Update main_analysis.py fix missing dir issue * bump version * Update smarteole_example.ipynb * Update smarteole_example.ipynb filter SmallSampleWarning * Update smarteole_example.ipynb fix ruff issue * Create wind-up uplift validation methodology.pdf * Cleanup requests dependency and move to examples group (#19) * Cleanup requests dependency and move to examples group * Jupyter group moved to examples and all group added * Update pyproject.toml define all using other groups --------- Co-authored-by: Alex Clerc <[email protected]> * support Python 3.9 (#17) * try Python 3.9 in workflow * Update lint-and-test.yaml * try from __future__ import annotations * Update conftest.py * add eval-type-backport * more from __future__ import annotations * remove TypeAlias * replace zip with strict_zip * ignore 3.9 mypy issues * fix bug in backporting.py * Update lint-and-test.yaml * Update lint-and-test.yaml * Update pyproject.toml move types-requests to dev * Update smarteole_example.ipynb * Update smarteole_example.ipynb * Update smarteole_example.ipynb * Define supported python (#23) * add badge to README * Update pyproject.toml * Update lint-and-test.yaml * update classifiers * Update lint-and-test.yaml * Update README.md * Update smarteole_example.ipynb * Update lint-and-test.yaml * Update README.md * Update smarteole_example.ipynb * fix methodology link --------- Co-authored-by: Gorkem Kacar <[email protected]>
No description provided.