Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up requests dependency #18

Closed
aclerc opened this issue Sep 5, 2024 · 2 comments
Closed

clean up requests dependency #18

aclerc opened this issue Sep 5, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aclerc
Copy link
Contributor

aclerc commented Sep 5, 2024

I think requests might only be used in the examples so it's not needed in the main list of dependencies. Investigate defining an examples dependency group (maybe re-define the jupyter group) to clean this up
@aclerc aclerc added enhancement New feature or request good first issue Good for newcomers labels Sep 5, 2024
@izofat
Copy link
Contributor

izofat commented Sep 5, 2024

Hi.
I fixed the issue.
I did some investigation but it didn't see usage of requests outside of examples.
Created a new group named examples.
If you think re-defining the jupyter group is better let me know.

#19

@aclerc
Copy link
Contributor Author

aclerc commented Sep 6, 2024

Thank you @izofat ! PR is merged

@aclerc aclerc closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aclerc @izofat