Replace RestClient gem with HTTP #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abotalov
force-pushed
the
replace-rest-client-with-http
branch
from
01ae9ee to
a4ed59d
Compare
Closed
abotalov
force-pushed
the
replace-rest-client-with-http
branch
from
a4ed59d to
f94e004
Compare
alalayla
reviewed
Aug 13, 2019
| response | ||
| else | ||
| p "ReportPortal API returned #{response}" | ||
| p "Offending request method/URL: #{request.args[:method].upcase} #{request.args[:url]}" |
There was a problem hiding this comment.
Does http handle errors in the same way?
There was a problem hiding this comment.
HTTP handles errors in a bit different way. If there is no response from server (connection error, SSL error, DNS error) an error is raised. If there is a response, its code can be inspected.
alalayla
approved these changes
Aug 16, 2019
|
#59 now reuses the connection |
abotalov
force-pushed
the
replace-rest-client-with-http
branch
from
f38e132 to
c61d142
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the reasons for replacing gem: