Replace RestClient gem with HTTP

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-07-01 15:09:18 +0200 using RuboCop version 0.69.0.
+# on 2019-08-12 11:40:23 +0300 using RuboCop version 0.71.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -13,14 +13,13 @@ Layout/EmptyLineAfterGuardClause:
     - 'lib/report_portal/cucumber/json_slurper.rb'
     - 'tests/features/step_definitions/steps.rb'
 
-# Offense count: 5
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
 # SupportedStyles: space, no_space, compact
 # SupportedStylesForEmptyBraces: space, no_space
 Layout/SpaceInsideHashLiteralBraces:
   Exclude:
-    - 'lib/reportportal.rb'
     - 'tests/formatter_spec.rb'
 
 # Offense count: 1
@@ -39,7 +38,7 @@ Lint/UriEscapeUnescape:
   Exclude:
     - 'lib/reportportal.rb'
 
-# Offense count: 18
+# Offense count: 15
 Metrics/AbcSize:
   Max: 106
 
@@ -58,27 +57,20 @@ Metrics/ClassLength:
 Metrics/CyclomaticComplexity:
   Max: 13
 
-# Offense count: 19
+# Offense count: 17
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 79
 
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 162
+  Max: 125
 
 # Offense count: 5
 Metrics/PerceivedComplexity:
   Max: 14
 
-# Offense count: 3
-# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db
-Naming/UncommunicativeMethodParamName:
-  Exclude:
-    - 'lib/report_portal/patches/rest_client.rb'
-
 # Offense count: 1
 # Cop supports --auto-correct.
 Security/YAMLLoad:
@@ -98,15 +90,7 @@ Style/CommentedKeyword:
   Exclude:
     - 'lib/report_portal/cucumber/report.rb'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
-# SupportedStyles: assign_to_condition, assign_inside_condition
-Style/ConditionalAssignment:
-  Exclude:
-    - 'lib/reportportal.rb'
-
-# Offense count: 9
+# Offense count: 7
 Style/Documentation:
   Exclude:
     - 'spec/**/*'
@@ -115,7 +99,6 @@ Style/Documentation:
     - 'lib/report_portal/cucumber/parallel_formatter.rb'
     - 'lib/report_portal/cucumber/parallel_report.rb'
     - 'lib/report_portal/logging/logger.rb'
-    - 'lib/report_portal/patches/rest_client.rb'
     - 'lib/report_portal/rspec/formatter.rb'
     - 'lib/report_portal/settings.rb'
     - 'lib/reportportal.rb'
@@ -150,7 +133,7 @@ Style/FormatString:
 Style/FormatStringToken:
   EnforcedStyle: unannotated
 
-# Offense count: 21
+# Offense count: 20
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, never
@@ -174,13 +157,12 @@ Style/GuardClause:
     - 'lib/reportportal.rb'
     - 'tests/features/step_definitions/steps.rb'
 
-# Offense count: 3
+# Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
 # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
 Style/HashSyntax:
   Exclude:
-    - 'lib/reportportal.rb'
     - 'tests/formatter_spec.rb'
 
 # Offense count: 5
@@ -191,14 +173,6 @@ Style/IfUnlessModifier:
     - 'lib/report_portal/cucumber/report.rb'
     - 'tests/features/support/env.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, Autocorrect.
-# SupportedStyles: module_function, extend_self
-Style/ModuleFunction:
-  Exclude:
-    - 'lib/report_portal/patches/rest_client.rb'
-
 # Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
@@ -225,14 +199,6 @@ Style/PercentLiteralDelimiters:
   Exclude:
     - 'lib/report_portal/cucumber/json_slurper.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: implicit, explicit
-Style/RescueStandardError:
-  Exclude:
-    - 'lib/reportportal.rb'
-
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist.
@@ -254,14 +220,6 @@ Style/SignalException:
     - 'tests/features/support/env.rb'
     - 'tests/spec/test_spec.rb'
 
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: use_perl_names, use_english_names
-Style/SpecialGlobalVars:
-  Exclude:
-    - 'lib/reportportal.rb'
-
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
@@ -295,7 +253,7 @@ Style/TrailingCommaInHashLiteral:
   Exclude:
     - 'lib/report_portal/settings.rb'
 
-# Offense count: 104
+# Offense count: 99
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https

CHANGELOG.md

@@ -3,3 +3,5 @@
 ## In Git (not released)
 
 * reportportal/reportportal#293 - Re-licence client side to Apache 2.0
+* Remove retrying of all requests. Usually requests fail because of incorrect request parameters so retrying doesn't help and pollutes output.
+* Remove multipart monkeypatch of RestClient. Replace RestClient with HTTP gem as it supports multipart fine