-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination's pageSizeOptions Select component's showSearch props handled dynamically. #554
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ationProps interface
@MadCcc Waiting for this PR approval |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #554 +/- ##
=======================================
Coverage 98.70% 98.71%
=======================================
Files 3 3
Lines 310 311 +1
Branches 137 138 +1
=======================================
+ Hits 306 307 +1
Misses 4 4 ☔ View full report in Codecov by Sentry. |
@MadCcc I Waiting for PR approval long time. Can you check this PR code ASAP? |
@MadCcc How to update the testing snapshot in the rc-pagination repository? Please help it to resolve the above coverage check failure. |
Add some test case to fix coverage test failed. |
Combine all props related with sizeChanger together would be better, and could reuse props of Select. pageSizeChanger: {
onChange,
options,
showSearch,
} |
@prakashks20 how it's going? Do you need any help, because I need this fix as well? |
Move to #597 |
These review changes have been addressed in the pull request below. So, please close this pull request. |
These fix changes are completed and pull request has been created |
|
Ant Design Pagination enhanced feature added in ant-design/ant-design#46757 depends this PR changes