Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination's pageSizeOptions Select component's showSearch props handled dynamically. #554

Conversation

prakashks20
Copy link
Contributor

@prakashks20 prakashks20 commented Jan 2, 2024

Ant Design Pagination enhanced feature added in ant-design/ant-design#46757 depends this PR changes

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pagination ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 5:20pm

@prakashks20
Copy link
Contributor Author

@MadCcc Waiting for this PR approval

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (998957f) 98.70% compared to head (8efdfaa) 98.71%.
Report is 1 commits behind head on master.

❗ Current head 8efdfaa differs from pull request most recent head 0bcabf1. Consider uploading reports for the commit 0bcabf1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #554   +/-   ##
=======================================
  Coverage   98.70%   98.71%           
=======================================
  Files           3        3           
  Lines         310      311    +1     
  Branches      137      138    +1     
=======================================
+ Hits          306      307    +1     
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prakashks20
Copy link
Contributor Author

@MadCcc I Waiting for PR approval long time. Can you check this PR code ASAP?

@prakashks20
Copy link
Contributor Author

@MadCcc How to update the testing snapshot in the rc-pagination repository? Please help it to resolve the above coverage check failure.

@yoyo837
Copy link
Member

yoyo837 commented Jan 10, 2024

Add some test case to fix coverage test failed.

@MadCcc
Copy link
Member

MadCcc commented Jan 10, 2024

Combine all props related with sizeChanger together would be better, and could reuse props of Select.

pageSizeChanger: {
  onChange,
  options,
  showSearch,
}

@Enigama
Copy link

Enigama commented Mar 15, 2024

@prakashks20 how it's going? Do you need any help, because I need this fix as well?

@afc163
Copy link
Member

afc163 commented Jul 23, 2024

#554 (comment)

@yoyo837
Copy link
Member

yoyo837 commented Jul 25, 2024

Move to #597

@yoyo837 yoyo837 closed this Jul 25, 2024
@prakashks20
Copy link
Contributor Author

Ant Design Pagination enhanced feature added in ant-design/ant-design#46757 depends this PR changes

These review changes have been addressed in the pull request below. So, please close this pull request.

#597

@prakashks20
Copy link
Contributor Author

prakashks20 commented Jul 25, 2024

These review changes have been addressed in the pull request below. So, please close this pull request.

#597

These fix changes are completed and pull request has been created

@prakashks20
Copy link
Contributor Author

Ant Design Pagination enhanced feature added in ant-design/ant-design#46757 depends this PR changes

These review changes have been addressed in the pull request below. So, please close this pull request.

#597

@MadCcc @afc163 @Enigama FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants