Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination component's pageSizeOptions Select component showSearch handled dynamically #46757

Conversation

prakashks20
Copy link

@prakashks20 prakashks20 commented Jan 2, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 2, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 2, 2024

  • 🚨 Please fill changelog in the PR

    • Write with a developer-oriented perspective and narrative method, without describing the details of the repair
    • Describing the problem and the impact on the developer
    • describing the user-first site problem, not your solution
    • Refer: https://ant.design/changelog#501
  • 🚨 请填写 PR 中的 changelog

    • 请用面向开发者的角度叙述方式撰写,不描述修复细节
    • 描述问题和对开发者的影响
    • 描述用户第一现场的问题,而非你的解决方式
    • 参考:https://ant.design/changelog-cn#501

Copy link
Contributor

github-actions bot commented Jan 2, 2024

👁 Visual Regression Report for PR #46757 Failed ❌

🎯 Target branch: master (9c4d549)
📖 View Full Report ↗︎

Expected (Branch master) Actual (Current PR) Diff
pagination-pageSizeChanger.compact.css-var.png pagination-pageSizeChanger.compact.css-var.png 🆕🆕🆕 Added 🆕🆕🆕
pagination-pageSizeChanger.compact.png pagination-pageSizeChanger.compact.png 🆕🆕🆕 Added 🆕🆕🆕
pagination-pageSizeChanger.dark.css-var.png pagination-pageSizeChanger.dark.css-var.png 🆕🆕🆕 Added 🆕🆕🆕
pagination-pageSizeChanger.dark.png pagination-pageSizeChanger.dark.png 🆕🆕🆕 Added 🆕🆕🆕
pagination-pageSizeChanger.default.css-var.png pagination-pageSizeChanger.default.css-var.png 🆕🆕🆕 Added 🆕🆕🆕
pagination-pageSizeChanger.default.png pagination-pageSizeChanger.default.png 🆕🆕🆕 Added 🆕🆕🆕

Check Full Report for details


If you think the visual diff is acceptable, please check:

  • Visual diff is acceptable

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Preview failed

@prakashks20
Copy link
Author

prakashks20 commented Jan 2, 2024

react-component/pagination#554
react-component/pagination#597
This pull request should be merged after the above pull request has been merged.

@prakashks20 prakashks20 force-pushed the featrure/development/Pagination-pageSizeOptions-Select-component's-showSearch-handled-dynamically branch from 5fe4c41 to 8d6472c Compare July 25, 2024 03:22
prakashks20 and others added 2 commits July 25, 2024 08:59
…tions-Select-component's-showSearch-handled-dynamically
…tions-Select-component's-showSearch-handled-dynamically
@afc163
Copy link
Member

afc163 commented Sep 22, 2024

Supported in #50952

@afc163 afc163 closed this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants