Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Make include_log_monitor configurable in the ray start command #48891

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[core] Make include_log_monitor configurable in the ray start command #48891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
518171e
update
kevin85421 Nov 23, 2024
d4adeaa
update
kevin85421 Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions python/ray/scripts/scripts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,15 @@ def debug(address: str, verbose: bool):
type=str,
help="a JSON serialized dictionary mapping label name to label value.",
)
@click.option(
"--include-log-monitor",
default=None,
type=bool,
help="If set to True or left unset, a log monitor will start monitoring "
"the log files of all processes on this node and push their contents to GCS. "
"Only one log monitor should be started per physical host to avoid log "
"duplication on the driver process.",
)
@add_click_logging_options
@PublicAPI
def start(
Expand Down Expand Up @@ -668,6 +677,7 @@ def start(
ray_debugger_external,
disable_usage_stats,
labels,
include_log_monitor,
):
"""Start Ray processes manually on the local machine."""

Expand Down Expand Up @@ -757,6 +767,7 @@ def start(
no_monitor=no_monitor,
tracing_startup_hook=tracing_startup_hook,
ray_debugger_external=ray_debugger_external,
include_log_monitor=include_log_monitor,
)

if ray_constants.RAY_START_HOOK in os.environ:
Expand Down