Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Make include_log_monitor configurable in the ray start command #48891

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Nov 23, 2024

Why are these changes needed?

In #48642, the user creates two Ray nodes in the local environment, causing both the head and worker nodes to launch a log monitor process. As a result, the logs are printed in the driver process twice.

This PR makes --include-log-monitor configurable, allowing users to launch a log monitor process only when starting the head node, preventing duplicate logs.

# test.py
import ray

@ray.remote
def foo():
    print('hello')


if __name__ == '__main__':
    ray.init()
    handle = foo.remote()
    ray.get(handle)
image

Related issue number

Closes #48642

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: kaihsun <[email protected]>
Copy link
Collaborator

@MengjinYan MengjinYan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a general question: Wondering should also add the logic where we automatically set the include_log_monitor to false when there is more than 1 log monitor is running on a physical host?

python/ray/scripts/scripts.py Outdated Show resolved Hide resolved
@kevin85421
Copy link
Member Author

I have a general question: Wondering should also add the logic where we automatically set the include_log_monitor to false when there is more than 1 log monitor is running on a physical host?

I initially attempted to automatically detect this situation (PR: #48676). However, the log monitor is not the only issue when running multiple Ray nodes on a single physical host. Therefore, @rkooo567 suggested providing an option to disable the log monitor instead.

Signed-off-by: kaihsun <[email protected]>
@MengjinYan MengjinYan added the go add ONLY when ready to merge, run all tests label Nov 25, 2024
@jjyao jjyao merged commit 5e661d2 into ray-project:master Nov 26, 2024
6 checks passed
jecsand838 pushed a commit to jecsand838/ray that referenced this pull request Dec 4, 2024
dentiny pushed a commit to dentiny/ray that referenced this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Logs are duplicated if multiple nodes are running on same machine
3 participants