Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disallow fallback to Make in wheel builds #1804

Merged
merged 2 commits into from
Jan 31, 2025
Merged

disallow fallback to Make in wheel builds #1804

merged 2 commits into from
Jan 31, 2025

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 30, 2025 •
edited
Loading

Description

Contributes to rapidsai/build-planning#146

Proposes:

  • setting [tool.scikit-build].ninja.make-fallback = false, so scikit-build-core will not silently fallback to using GNU Make if ninja is not available

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb
disallow fallback to Make in wheel builds, always use 'requirements' …
f40acc2 
…and 'pyproject' together in dependencies.yaml
@jameslamb jameslamb added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 30, 2025
@jameslamb jameslamb requested a review from bdice January 30, 2025 21:52
@jameslamb jameslamb requested a review from a team as a code owner January 30, 2025 21:52
@github-actions github-actions bot added the Python Related to RMM Python API label Jan 30, 2025
jameslamb
jameslamb commented Jan 30, 2025
View reviewed changes
dependencies.yaml Outdated Show resolved Hide resolved
@jameslamb jameslamb mentioned this pull request Jan 30, 2025
Open
bdice
bdice approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a minor request.

@jameslamb @bdice
Update dependencies.yaml
7825f6d 
Co-authored-by: Bradley Dice <[email protected]>
@jameslamb jameslamb changed the title disallow fallback to Make in wheel builds, always use 'requirements' and 'pyproject' together in dependencies.yaml disallow fallback to Make in wheel builds Jan 31, 2025
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 05e810a into rapidsai:branch-25.04 Jan 31, 2025
59 checks passed
@jameslamb jameslamb deleted the no-ninja-make-fallback branch January 31, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @bdice