Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ninja is used in wheel builds 🥷 #146

Open
4 of 16 tasks
jameslamb opened this issue Jan 30, 2025 · 3 comments
Open
4 of 16 tasks

Ensure ninja is used in wheel builds 🥷 #146

jameslamb opened this issue Jan 30, 2025 · 3 comments
Assignees

Comments

@jameslamb
Copy link
Member

jameslamb commented Jan 30, 2025

Description

We found recently that some projects' wheel builds were falling back to GNU Make because ninja was (unintentionally) not available in their build environments.

Noticed by the presence of lines like this in CMake output:

*** Building project with Unix Makefiles...

We should audit all of the RAPIDS libraries for the following:

  • ninja being used in wheel-building environments
  • ninja.make-fallback = false in [tool.scikit-build] in pyproject.toml (to raise an error if ninja is not available)
  • in dependencies.yaml, output-types: should almost always contains either both of pyproject and requirements or neither

Benefits of this work

  • faster wheel builds

Approach

These can be done in any order.

libraries about to enter code freeze

Preview Give feedback

Notes

related: #108

@jameslamb jameslamb self-assigned this Jan 30, 2025
@bdice bdice changed the title Ensure minja is used in wheel builds Ensure ninja is used in wheel builds 🥷 Jan 30, 2025
@jameslamb
Copy link
Member Author

Just reviewed all of these libraries, happy to say that all but cuGraph are successfully building with Ninja today. So the changes for this issue will just be minor cleanup and a bit of added protection against this bug re-occurring.

Given that and where we are in the current release cycle, I'm going to target this issue and the PRs at branch-25.04.

@jakirkham
Copy link
Member

Thanks James! 🙏

Since we are looking, can we confirm the same is true for Conda?

@bdice
Copy link
Contributor

bdice commented Jan 31, 2025

We can check on conda too, just to be sure, but I think we're in good shape on that front.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants