-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure ninja is used in wheel builds 🥷 #146
Comments
Just reviewed all of these libraries, happy to say that all but cuGraph are successfully building with Ninja today. So the changes for this issue will just be minor cleanup and a bit of added protection against this bug re-occurring. Given that and where we are in the current release cycle, I'm going to target this issue and the PRs at |
Thanks James! 🙏 Since we are looking, can we confirm the same is true for Conda? |
We can check on conda too, just to be sure, but I think we're in good shape on that front. |
Contributes to rapidsai/build-planning#146 Proposes: * setting `[tool.scikit-build].ninja.make-fallback = false`, so `scikit-build-core` will not silently fallback to using GNU Make if `ninja` is not available Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1804
Description
We found recently that some projects' wheel builds were falling back to GNU Make because
ninja
was (unintentionally) not available in their build environments.Noticed by the presence of lines like this in CMake output:
*** Building project with Unix Makefiles...
We should audit all of the RAPIDS libraries for the following:
ninja
being used in wheel-building environmentsninja.make-fallback = false
in[tool.scikit-build]
inpyproject.toml
(to raise an error ifninja
is not available)dependencies.yaml
,output-types:
should almost always contains either both ofpyproject
andrequirements
or neitherBenefits of this work
Approach
These can be done in any order.
libraries about to enter code freeze
others
Notes
related: #108
The text was updated successfully, but these errors were encountered: