Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the misplaced libcurl in CMake #587

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix the misplaced libcurl in CMake #587

merged 1 commit into from
Jan 14, 2025

Conversation

kingcrimsontianyu
Copy link
Contributor

This PR fixes a CMake bug introduced in #581 where libcurl is unconditionally compiled.

@kingcrimsontianyu kingcrimsontianyu added bug Something isn't working non-breaking Introduces a non-breaking change c++ Affects the C++ API of KvikIO labels Jan 14, 2025
@kingcrimsontianyu kingcrimsontianyu self-assigned this Jan 14, 2025
@kingcrimsontianyu kingcrimsontianyu requested a review from a team as a code owner January 14, 2025 19:53
@kingcrimsontianyu
Copy link
Contributor Author

/merge

abellina
abellina approved these changes Jan 14, 2025
View reviewed changes
Copy link

@abellina abellina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built spark-rapids-jni with this change, and we are unblocked. Thank you.

@abellina abellina mentioned this pull request Jan 14, 2025
Closed
@rapids-bot rapids-bot bot merged commit a847c07 into rapidsai:branch-25.02 Jan 14, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

@bdice bdice bdice approved these changes

@abellina abellina abellina approved these changes

Assignees

@kingcrimsontianyu kingcrimsontianyu

Labels
bug Something isn't working c++ Affects the C++ API of KvikIO non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kingcrimsontianyu @abellina @bdice @KyleFromNVIDIA