Skip to content

Commit

Permalink
Fix the misplaced libcurl in CMake (#587)
Browse files Browse the repository at this point in the history
This PR fixes a CMake bug introduced in #581 where `libcurl` is unconditionally compiled.

Authors:
  - Tianyu Liu (https://github.com/kingcrimsontianyu)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Bradley Dice (https://github.com/bdice)
  - Alessandro Bellina (https://github.com/abellina)

URL: #587
  • Loading branch information
kingcrimsontianyu authored Jan 14, 2025
1 parent 66508db commit a847c07
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,13 @@ set(SOURCES
"src/posix_io.cpp"
"src/shim/cuda.cpp"
"src/shim/cufile.cpp"
"src/shim/libcurl.cpp"
"src/shim/utils.cpp"
"src/stream.cpp"
"src/utils.cpp"
)

if(KvikIO_REMOTE_SUPPORT)
list(APPEND SOURCES "src/remote_handle.cpp")
list(APPEND SOURCES "src/remote_handle.cpp" "src/shim/libcurl.cpp")
endif()

add_library(kvikio ${SOURCES})
Expand Down

0 comments on commit a847c07

Please sign in to comment.