Revert "Enable 'quiet: true' in condarc" #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b26d564.
jameslamb
approved these changes
Dec 23, 2024
pentschev
approved these changes
Dec 23, 2024
This was referenced Jan 16, 2025
|
Could you please share a bit more what information is lost? Some examples would be instructive |
|
The exact problem is that when we enable quiet mode, Python exception names are no longer being printed. This makes rapids-conda-retry ineffective, as it depends on parsing logs for exception names to decide whether to retry. |
|
Ah, there is a better continuation of this discussion in #228. Let’s continue there. |
|
Please feel free to share some examples in that thread. Links to logs are ok. Just need something with more detail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #217.
It seems like we have lost some useful information from conda, and Python exception names are no longer being printed. This makes rapids-conda-retry ineffective. @pentschev and I suspect the change to quiet mode may be the root cause. We would like to try reverting it to see if this changes.
We may also need to do something to make conda stop printing all the extra newlines in progress bars that led to #217 in the first place…