-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conda logs have many empty lines #228
Comments
While we are rolling out consolidated installs ( rapidsai/build-planning#22 ), which fixes some install flakiness that we see in different places (plus cuts down on test install time), we can add a Should add would welcome other folks to also make these PRs. Think anyone on build-infra could help move this forward |
Consolidating installs is great and has its own standalone value. I'm 100% convinced in the value of doing that. But I don't think that directly addresses the issue of "CI logs are full of hundreds of empty lines from progress bars". And from #220 and the discussion that led to it, I think we're not confident that adding This would benefit from a minimal, reproducible example and some investigation to validate that, which is part of what this issue tracks. |
That is what the Wasn't around when this discussion occurred. Would appreciate having some examples and context for why we think Should add we have been using |
Right, I understand. This is why I said:
|
Yep just hard to create minimal viable reproducer without even an example. So for now will wait until someone who saw these issues can share more information |
@pentschev noticed quite a few of these errors in the ucxx CI. Here are links to a few errors where Python exceptions were not shown, and we instead got cryptic messages.
Notice that the logs in these links are indeed very quiet! They hide a lot of information that we normally would see. We really just want to turn off the progress bars. |
I recently saw similar issues to what @bdice mentioned above, but in this repo: One other random thought (haven't investigated this).... I wonder if some of these things are related to the fact that we're wrapping
And so I wonder if that could be causing some of these issues? For example,
Maybe |
Description
For example, see https://github.com/rapidsai/cuml/actions/runs/12799823619/job/35687977337?pr=6227
That small screenshot shows 7 lines worth of information taking up 40 lines of space. Sometimes the ratio is even worse:
We'd attempted to fix this by setting
quiet: true
in the conda config in CI images (rapidsai/build-planning#126, #217).But had to revert that because that seemed to suppress Python exception names when
conda
operations failed, which we suspect broke the retrying mechanism we use to retry conda operations (#220, gha-tools / tools / rapids-conda-retry).As a result of that reversion, this logging issue is still a problem adding friction to development (example: rapidsai/cuml#6224 (comment)).
Reproducible Example
See any recent CI runs across RAPIDS that perform a
{conda, mamba} env create
or{conda, mamba} env install
.example: https://github.com/rapidsai/cuml/actions/runs/12799823619/job/35687977337?pr=6227
Notes
It'd be helpful to find the root cause of this, and ideally a reproducible example that isn't RAPIDS-specific (in case this is an issue in
conda
/mamba
or some library they depend on).Any solution for RAPIDS should:
rapids-{conda,mamba}-retry
tool's error-detecting mechanismThe text was updated successfully, but these errors were encountered: