Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention CRD install for system-upgrade-controller #228

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

dereknola
Copy link
Member

Addresses: #222

Signed-off-by: Derek Nola [email protected]

@dereknola dereknola requested a review from a team as a code owner June 26, 2024 16:55
@manuelbuil
Copy link
Contributor

There is one caveat if we follow these steps, there are two resources (role and rolebinding) that fail to be created because the namespace was not yet created. The namespace gets created in system-upgrade-controller.yaml too but I guess it is not there yet when needed

 Error from server (NotFound): error when creating "https://github.com/rancher/system-upgrade-controller/releases/latest/download/system-upgrade-controller.yaml": namespaces "system-upgrade" not found
Error from server (NotFound): error when creating "https://github.com/rancher/system-upgrade-controller/releases/latest/download/system-upgrade-controller.yaml": namespaces "system-upgrade" not found

If I apply system-upgrade-controller.yaml again, it works. Maybe we should warn users about it?

@brandond
Copy link
Member

I have been meaning to get a bit more hands-on with that repo; I allowed some folks to make changes to the deployment manifests that in retrospect only work well when using kustomize, and have made things a bit more painful if just using kubectl apply as we suggest in other repos docs.

@manuelbuil
Copy link
Contributor

manuelbuil commented Jun 28, 2024

I have been meaning to get a bit more hands-on with that repo; I allowed some folks to make changes to the deployment manifests that in retrospect only work well when using kustomize, and have made things a bit more painful if just using kubectl apply as we suggest in other repos docs.

Agree, I think the user experience became worse. 0.13.2 was simple to install

Signed-off-by: Derek Nola <[email protected]>
@dereknola
Copy link
Member Author

Regardless of making SUC better, this does fix the upgrade docs to at least work.

@dereknola dereknola merged commit 70cff1c into rancher:main Aug 9, 2024
@dereknola dereknola deleted the crds branch August 9, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants