Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update system upgrade controller #1091

Open
fmoral2 opened this issue Dec 21, 2023 · 2 comments
Open

update system upgrade controller #1091

fmoral2 opened this issue Dec 21, 2023 · 2 comments
Assignees

Comments

@fmoral2
Copy link

fmoral2 commented Dec 21, 2023

we need to update https://github.com/rancher/system-upgrade-controller/releases/tag/v0.13.2

relates to #799

@aganesh-suse
Copy link

we should be using the 'latest' tag always for the system upgrade controller - without having a hardcoded suc.yaml file that we apply for the suc tests.
kubectl apply -f https://github.com/rancher/system-upgrade-controller/releases/latest/download/system-upgrade-controller.yaml

it also looks like we might need to also apply another crd.yaml (starting v0.13.2 through v.0.13.4)
https://github.com/rancher/system-upgrade-controller/releases/latest/download/crd.yaml

will update here if this changes.

so for version v0.13.2 - v0.13.4 to work:

kubectl apply -f https://github.com/rancher/system-upgrade-controller/releases/latest/download/system-upgrade-controller.yaml
kubectl apply -f https://github.com/rancher/system-upgrade-controller/releases/latest/download/system-upgrade-controller.yaml
https://github.com/rancher/system-upgrade-controller/releases/latest/download/crd.yaml

per rancher/rke2-docs#228 (comment)

@aganesh-suse
Copy link

aganesh-suse commented Jul 29, 2024

The steps will need to be modified based on the outcome of: rancher/system-upgrade-controller#317

We need to be able to provide a flag on the test for giving a 'sucversion' (default to 'latest' tag if not provided) - that way if 'latest' broke, we can fall back on a known version to run the test.

@aganesh-suse aganesh-suse self-assigned this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants