ENH: accept additional featuretable types #231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #230
Adds additional feature table types to the acceptable inputs for various classification and regression methods. For now I have only added types that have non-negative values or at least have descriptions to clarify what these contain (i.e., not balance or percentile abundance).
Question: would you like to see unit tests for each type? I checked out q2-feature-table for precedent, where it looks like different types are not tested for actions that accept multiple types. As the internal format is identical for these types, any tests would be redundant. So for now I have not added tests so we can discuss first.