Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2007-4559 Patch #220

Merged
merged 6 commits into from
Dec 11, 2023
Merged

CVE-2007-4559 Patch #220

merged 6 commits into from
Dec 11, 2023

Conversation

TrellixVulnTeam
Copy link
Contributor

Patching CVE-2007-4559

Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.

If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.

@cherman2 cherman2 self-requested a review December 11, 2023 17:27
Copy link
Contributor

@cherman2 cherman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending CI passing

@cherman2 cherman2 self-requested a review December 11, 2023 18:32
@cherman2
Copy link
Contributor

Still need to pull down and test!

@cherman2
Copy link
Contributor

tested this down and tested it on local machine, and tested with real data.

@cherman2 cherman2 merged commit 8596430 into qiime2:dev Dec 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants