IMP: more verbose error handling for merge method use cases #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinvwood
approved these changes
Apr 9, 2024
Co-authored-by: Liz Gehret <[email protected]>
Co-authored-by: Liz Gehret <[email protected]>
lizgehret
reviewed
Apr 25, 2024
lizgehret
approved these changes
May 1, 2024
There was a problem hiding this comment.
thanks for all of your hard work on this @hagenjp, this is g2g! i replaced the parens around the MD column types with single quotes in the error message, just because i think it renders a bit nicer - but didn't think that warranted another round of reviews and didn't want to toss it back to you for something that small. once this passes ci, i'll go ahead and merge!
lizgehret
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #63
closes #62