Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linker error #33

Merged
merged 2 commits into from
Apr 5, 2024
Merged

fix linker error #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f21b76
link
turuslan Apr 3, 2024
476a1f4
venv
turuslan Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/aux/github_venv.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#
# Copyright Quadrivium LLC
# All Rights Reserved
# SPDX-License-Identifier: Apache-2.0
#

GITHUB_ENV="${GITHUB_ENV:?}"
export VIRTUAL_ENV="${1:?venv path not set}"
export PATH="$VIRTUAL_ENV/bin:$PATH"
echo "VIRTUAL_ENV=$VIRTUAL_ENV" >> "$GITHUB_ENV"
echo "PATH=$PATH" >> "$GITHUB_ENV"
8 changes: 5 additions & 3 deletions .github/workflows/compilers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ jobs:
clean: true
fetch-depth: 1

- name: venv
run: python3 -m venv --upgrade-deps ~/venv && .github/aux/github_venv.sh $_

- name: install dependencies
run: |
set -e
Expand All @@ -60,9 +63,8 @@ jobs:
sudo update-alternatives --install /usr/bin/gcov gcov /usr/bin/gcov-13 90
fi

sudo python3 -m pip install --upgrade pip
sudo python3 -m pip install scikit-build
sudo python3 -m pip install cmake==3.25 requests gitpython gcovr pyyaml
pip3 install scikit-build
pip3 install cmake==3.25 requests gitpython gcovr pyyaml

- name: cmake
env:
Expand Down
3 changes: 3 additions & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ add_library(configurator_yaml
target_link_libraries(configurator_yaml
yaml-cpp::yaml-cpp
configurator
logging_system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suggestion if implementation of configurator should know about logging_system.
I made issue #34 to resolve it.

)

add_library(fallback_configurator
Expand All @@ -100,6 +101,8 @@ add_library(logging_system
logging_system.cpp
)
target_link_libraries(logging_system
group
logger
sink
sink_to_nowhere
)
Expand Down
Loading