fix linker error #33
Merged
fix linker error #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turuslan
commented
Apr 3, 2024
turuslan
commented
- fixes libp2p ci refactor (for qtils) libp2p/cpp-libp2p#225
xDimon
approved these changes
Apr 5, 2024
| @@ -87,6 +87,7 @@ add_library(configurator_yaml | |||
| target_link_libraries(configurator_yaml | |||
| yaml-cpp::yaml-cpp | |||
| configurator | |||
| logging_system | |||
There was a problem hiding this comment.
I have suggestion if implementation of configurator should know about logging_system.
I made issue #34 to resolve it.
xDimon
added a commit
that referenced
this pull request
Oct 14, 2024
* update: clang-format rules Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * update: format the following updated rules Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * feature: max level for sink Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * update: explaining comment of config options Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * fix: some crashes at log configuration Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * update: clang-tidy rules Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * update: CI workflows Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * fix: clang-tidy issues Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * fix linker error (#33) Signed-off-by: turuslan <[email protected]> (cherry picked from commit 444f3da) --------- Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> (cherry picked from commit 042712e)
xDimon
added a commit
that referenced
this pull request
Oct 14, 2024
* update: clang-format rules Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * update: format the following updated rules Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * feature: max level for sink Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * update: explaining comment of config options Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * fix: some crashes at log configuration Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * update: clang-tidy rules Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * update: CI workflows Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * fix: clang-tidy issues Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * fix linker error (#33) Signed-off-by: turuslan <[email protected]> (cherry picked from commit 444f3da) --------- Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> (cherry picked from commit 042712e)
xDimon
added a commit
that referenced
this pull request
Oct 14, 2024
* Feature: sink level * update: clang-format rules Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * update: format the following updated rules Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * feature: max level for sink Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * update: explaining comment of config options Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * fix: some crashes at log configuration Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * update: clang-tidy rules Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * update: CI workflows Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * fix: clang-tidy issues Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * fix linker error (#33) Signed-off-by: turuslan <[email protected]> (cherry picked from commit 444f3da) * fix: workflows Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> --------- Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.