Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.3 to CI and cleanup CI config #52

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Add Ruby 3.3 to CI and cleanup CI config #52

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aea5cd5
CI: Run on Ubuntu 22.04 runners
bastelfreak Jun 18, 2024
a511c2f
Add Ruby 3.3 to CI
bastelfreak Jun 18, 2024
aca7593
CI: Cleanup gem installation
bastelfreak Jun 18, 2024
0dc403d
CI: Test gem builds
bastelfreak Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions .github/workflows/rspec_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,11 @@ jobs:
strategy:
matrix:
cfg:
- {os: ubuntu-20.04, ruby: '2.7'}
- {os: ubuntu-20.04, ruby: '3.0'}
- {os: ubuntu-20.04, ruby: '3.2'}
- {os: ubuntu-20.04, ruby: 'jruby-9.4.2'}
- {os: ubuntu-22.04, ruby: '2.7'}
- {os: ubuntu-22.04, ruby: '3.0'}
- {os: ubuntu-22.04, ruby: '3.2'}
- {os: ubuntu-22.04, ruby: '3.3'}
- {os: ubuntu-22.04, ruby: 'jruby-9.4.2'}
- {os: windows-2019, ruby: '2.7'}
- {os: windows-2019, ruby: '3.0'}
- {os: windows-2019, ruby: '3.2'}
Expand All @@ -30,11 +31,7 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.cfg.ruby }}

- name: Update rubygems and install gems
run: |
gem update --system --silent --no-document
bundle config set without packaging
bundle install --jobs 4 --retry 3

- run: bundle exec rake spec
bundler-cache: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating rubygems used to be necessary for some or our older rubies. Curious as to why this was dropped and replaced with bundler-cache? Could you add comments in the git commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this keyword is a bit... misleading. It's required to install the gems from the Gemfile and it will do caching. between CI runs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the commit with a description

- run: bundle exec rake spec
- name: Verify gem builds
run: gem build --verbose *.gemspec