Add Ruby 3.3 to CI and cleanup CI config #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcooper
reviewed
Jun 18, 2024
| bundle config set without packaging | ||
| bundle install --jobs 4 --retry 3 | ||
|
|
||
| bundler-cache: true |
There was a problem hiding this comment.
Updating rubygems used to be necessary for some or our older rubies. Curious as to why this was dropped and replaced with bundler-cache? Could you add comments in the git commit?
There was a problem hiding this comment.
this keyword is a bit... misleading. It's required to install the gems from the Gemfile and it will do caching. between CI runs.
There was a problem hiding this comment.
updated the commit with a description
by setting `bundler-cache: true` the action will automatically install the gems from Gemfile and we don't need a manual `bundle install`. It will also cache gems between CI runs. That's the default within the Vox Pupuli org and I think it makes sense here as well.
joshcooper
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.